Fix Update of Users with Alias during Login #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianhoelzl-sap
added
the
DO NOT MERGE
hsinn0
approved these changes
Aug 29, 2024
adrianhoelzl-sap
removed
the
DO NOT MERGE
adrianhoelzl-sap
commented
Sep 4, 2024
server/src/main/java/org/cloudfoundry/identity/uaa/scim/bootstrap/ScimUserBootstrap.java
Outdated
Show resolved
Hide resolved
…y update original user while alias properties remain unchanged
adrianhoelzl-sap
deleted the
fix-update-of-users-with-alias-during-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a user logs in, their properties, e.g.,
externalId, are updated with the corresponding values from the IdP (e.g., the ID token in case of OIDC).This update operation does not work for users with an alias. Such users are synchronized with an identical user in a different identity zone and reference each other through the properties
aliasIdandaliasZid.Since the update operation performed during the login does not handle these alias properties correctly, the user is updated without the changes being propagated to the alias. Furthermore, the alias properties are set to
null, which breaks the alias reference from this side.